WHO Tuberculosis Preventive Treatment Import#2001
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new statistical variable import for WHO Tuberculosis preventive treatment data, including a Python download script, manifest configuration, and associated metadata. Feedback focuses on a critical logic error in the property-value mapping where a scaling factor would incorrectly multiply percentage values. Additionally, several configuration errors were noted, such as incorrect filenames in the manifest, invalid paths in the README instructions, and formatting issues like a BOM character and inconsistent naming conventions in the schema MCF files. Improvements to the download script's error handling were also suggested.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
Please find the PR Checklist: [https://docs.google.com/spreadsheets/d/1fmOgPpbf3zao7ouz8elEKxTtWmOxj0OrOEkUQzk92yI/edit?resourcekey=0--OoqVHRDwzvT84pVUGSFMA&gid=1825756362#gid=1825756362]